<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112438/">http://git.reviewboard.kde.org/r/112438/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112438/diff/5/?file=186459#file186459line7" style="color: black; font-weight: bold; text-decoration: underline;">plugins/pintxo/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">message</span><span class="p">(</span><span class="s">FATAL_ERROR</span> <span class="s2">"ERROR: libModemManagerQt not found"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually I'd rather we make it so that we don't have modem manager we simply skip building this one plugin rather than fatal completely..
Ship it now, and we can change it later.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On September 2nd, 2013, 6:09 p.m. UTC, Anant Kamath wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Anant Kamath.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2013, 6:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Merge plugin for the SMS connection manager (pintxo)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/profiles/sms.profile <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/CMakeLists.txt <span style="color: grey">(b2af316891af14232c5aaa3eebcfd17802c6a1ca)</span></li>
<li>plugins/pintxo/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/ktpaccountskcm_plugin_pintxo.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/modem-combobox.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/modem-combobox.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/pintxo-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/pintxo-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/pintxo-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pintxo/pintxo-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112438/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/am1.jpeg">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>