<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112005/">http://git.reviewboard.kde.org/r/112005/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">\o/ 

You pushing this is going to break pursuviant.</pre>
 <br />







<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/112005/diff/3/?file=184033#file184033line21" style="color: black; font-weight: bold; text-decoration: underline;">KTp/message.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "message-private.h"</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This isn't in the diff.

Make sure you haven't missed it in a git add.
</pre>
</div>
<br />



<p>- David</p>


<br />
<p>On August 22nd, 2013, 2:21 p.m. UTC, Dan Vrátil wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>


<p style="color: grey;"><i>Updated Aug. 22, 2013, 2:21 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi guys,

on Akademy we discussed having our own logger that would provide abstraction 
over TpLoggerQt (and possibly other backends).

I've just pushed tp-logger branch in ktp-common-internals, which introduces 
KTp Logger - a library with API similar to what TpLoggerQt has and a plugin-
based design. There's already tplogger plugin which provides integration with 
Telepathy Logger via TpLoggerQt. TpLoggerQt is still just an optional 
dependency - without it the plugin will be disabled at build time.

For Windows, there also ktp-winlogger utility, which is an extremely super 
simple logger which stores logs into SQLite database and of course there's a 
plugin that provides integration with KTp Logger. It's automatically enabled 
on Windows, on Linux pass -DENABLE_WINLOGGER=TRUE to CMake. It works on Linux 
too :-)

In ktp-text-ui there is a ktplogger branch with logviewer completely ported to 
KTp Logger, so you can even test that it works :-) chat-ui and other 
components still have to be ported.
</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KTp/Logger/log-manager-private.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/log-entity.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/log-entity.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/ktp_logger_plugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/abstract-logger-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/CMakeLists.txt <span style="color: grey">(b514418)</span></li>

 <li>KTp/Logger/abstract-logger-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/log-manager.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/log-manager.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/log-message.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/log-message.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/log-search-hit.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/log-search-hit.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-dates-impl.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-dates-impl.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-dates.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-dates.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-entities-impl.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-entities-impl.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-entities.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-entities.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-logs-impl.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-logs-impl.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-logs.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-logs.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-operation.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-operation.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-search-impl.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-search-impl.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-search.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/pending-logger-search.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/ktploggerplugin_tplogger.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/pending-tp-logger-dates.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/pending-tp-logger-dates.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/pending-tp-logger-entities.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/pending-tp-logger-entities.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/pending-tp-logger-logs.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/pending-tp-logger-logs.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/pending-tp-logger-search.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/pending-tp-logger-search.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/tp-logger-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/utils.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/Logger/plugins/tplogger/utils.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>KTp/message-processor.h <span style="color: grey">(8ce92b2)</span></li>

 <li>KTp/message-processor.cpp <span style="color: grey">(e045d7b)</span></li>

 <li>KTp/message.h <span style="color: grey">(2953616)</span></li>

 <li>KTp/message.cpp <span style="color: grey">(36ea234)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112005/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>