<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112005/">http://git.reviewboard.kde.org/r/112005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 14th, 2013, 4:28 a.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112005/diff/2/?file=179216#file179216line37" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Logger/log-entity.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> <span class="n">KTP_EXPORT</span> <span class="n">LogEntity</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm a bit confused by this class as we appear to be using it for two things:
1) Get logs for this LogEntity
2) This message was from this entity
In the first case "alias" is pointless, in the second case "entityType" is pointless as it will always be a contact. For something with only 3 properties, having 2 useless half the time seems wrong?
I would consider only using this for saying who a message is from and when requesting use targetHandle, Tp::HandleType targetHandleType
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This class is equivalent to TpLogEntity.
We need to know what type it is when we query the entities, so that we can adjust UI for example (use groupchat theme). I agree we can omit alias.
</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 14th, 2013, 4:28 a.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112005/diff/2/?file=179220#file179220line75" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Logger/log-manager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">Private</span><span class="o">::</span><span class="n">s_logManagerInstance</span> <span class="o">==</span> <span class="mi">0</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KGLOBAL_STATIC is pretty awesome, it can take args, and I think it even deletes itself on app closedown.
You don't have to change it here, but it's worth learning for future stuff.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">K_GLOBAL_STATIC is to be removed in KF5, so I will just wait for Q_GLOBAL_STATIC :) </pre>
<br />
<p>- Dan</p>
<br />
<p>On August 13th, 2013, 9:49 p.m. CEST, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2013, 9:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi guys,
on Akademy we discussed having our own logger that would provide abstraction
over TpLoggerQt (and possibly other backends).
I've just pushed tp-logger branch in ktp-common-internals, which introduces
KTp Logger - a library with API similar to what TpLoggerQt has and a plugin-
based design. There's already tplogger plugin which provides integration with
Telepathy Logger via TpLoggerQt. TpLoggerQt is still just an optional
dependency - without it the plugin will be disabled at build time.
For Windows, there also ktp-winlogger utility, which is an extremely super
simple logger which stores logs into SQLite database and of course there's a
plugin that provides integration with KTp Logger. It's automatically enabled
on Windows, on Linux pass -DENABLE_WINLOGGER=TRUE to CMake. It works on Linux
too :-)
In ktp-text-ui there is a ktplogger branch with logviewer completely ported to
KTp Logger, so you can even test that it works :-) chat-ui and other
components still have to be ported.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Logger/log-manager-private.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/log-entity.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/log-entity.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/ktp_logger_plugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/abstract-logger-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/abstract-logger-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/CMakeLists.txt <span style="color: grey">(b514418db0da4ba41c13cbaea3591cba6b21ad5d)</span></li>
<li>KTp/Logger/log-manager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/log-manager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/log-message.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/log-message.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/log-search-hit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/log-search-hit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-dates-impl.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-dates-impl.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-dates.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-dates.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-entities-impl.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-entities-impl.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-entities.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-entities.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-logs-impl.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-logs-impl.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-logs.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-logs.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-operation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-operation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-search-impl.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-search-impl.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-search.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/pending-logger-search.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/ktploggerplugin_tplogger.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/pending-tp-logger-dates.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/pending-tp-logger-dates.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/pending-tp-logger-entities.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/pending-tp-logger-entities.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/pending-tp-logger-logs.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/pending-tp-logger-logs.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/pending-tp-logger-search.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/pending-tp-logger-search.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/tp-logger-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/utils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/tplogger/utils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/KTp.WinLogger.client <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/db.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/db.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/logger.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/logger.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/observer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/observer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/org.freedesktop.Telepathy.Client.KTp.WinLogger.service.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/logger/org.freedesktop.Telepathy.KTp.WinLogger.service.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/ktploggerplugin_winlogger.desktop.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/pending-win-logger-dates.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/pending-win-logger-dates.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/pending-win-logger-entities.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/pending-win-logger-entities.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/pending-win-logger-logs.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/pending-win-logger-logs.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/pending-win-logger-search.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/pending-win-logger-search.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/win-logger-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Logger/plugins/winlogger/plugin/win-logger-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/message-processor.h <span style="color: grey">(8ce92b2a91c2839167ea19885166cb4e878333f0)</span></li>
<li>KTp/message-processor.cpp <span style="color: grey">(e045d7bf335bdf9b8ec9b975e147f13ef8575acb)</span></li>
<li>KTp/message.h <span style="color: grey">(29536168c5e140f02c67c16fd705c66e9753fe0e)</span></li>
<li>KTp/message.cpp <span style="color: grey">(36ea23479034b48e8e1f580625de855af64faf34)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>