<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112188/">http://git.reviewboard.kde.org/r/112188/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit fb28de93e26b6c24a9667a16b21259e1737b3d25 by Dan Vrátil to branch kde-telepathy-0.6.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 22nd, 2013, 12:35 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Aug. 22, 2013, 12:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When LogsImporter is deleted, it just deletes the importer thread even when it's running, which will obviously crash.
This patch adds a safety guard (calling QThread::wait() before deleting it) and a method to stop the thread prematurely so that we don't wait() for the entire import to finish (just for current document to finish). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/logs-importer.cpp <span style="color: grey">(926d265)</span></li>
<li>KTp/logs-importer-private.h <span style="color: grey">(06c9c0d)</span></li>
<li>KTp/logs-importer-private.cpp <span style="color: grey">(7275b07)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112188/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>