<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112043/">http://git.reviewboard.kde.org/r/112043/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2013, 12:20 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fine with me.
It's a behaviour change so I'll wait a bit for anyone else to comment before I ship it.</pre>
</blockquote>
<p>On August 13th, 2013, 9:25 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fine with me as well. "Typing" is not important enough to indicate it in a redundant and confusing way.</pre>
</blockquote>
<p>On August 13th, 2013, 9:32 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fwiw, the first implementation was working correctly - only when the user in active tab was typing, the window title would change. This is broken now and should be fixed. If Thomas thinks fixing by complete removing is good, then ship it from me as well.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, we might even consider removing any "typing" indication from the window information, for the reasons detailed here: http://sessellift.wordpress.com/2013/04/18/periphery-grab-attention/
The information whether the person on the other side of a chat is typing is useful while actively chatting (because you might stop spamming her with your messages while she's still typing a longer reply, in order not to distract her from typing).
On the other hand, if your chat window is minimized, you most likely are not currently actively chatting, but just keeping it open in case the other person might send a message at some point.
Therefore in this situation, the "typing" information becomes a mere distraction. You only need to be informed when you actually receive a message, because this is the point where you might want to return to actively chatting again.
Since the "typing" information may change often if a person types a longer message in small chinks with pauses in between, you may end up with a constant distraction on your visual periphery without any useful information (since no message has been sent yet).</pre>
<br />
<p>- Thomas</p>
<br />
<p>On August 13th, 2013, 12:16 a.m. UTC, Daniel Cohen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniel Cohen.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2013, 12:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a user is talking to multiple people, it is confusing to have 'Typing... Bob', when it's actually Fred in another tab who is typing.
The presence of the both the chat tab status-icon change combined with the tab name text colour change is sufficient to denote activity and removes this confusion which is exacerbated with the more chat tabs that you have open.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tabs still change icon and colour upon user typing/message received.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.cpp <span style="color: grey">(d829125)</span></li>
<li>app/chat-window.h <span style="color: grey">(3a5b6ba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112043/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>