<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111501/">http://git.reviewboard.kde.org/r/111501/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 14th, 2013, 1:41 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111501/diff/1/?file=170559#file170559line76" style="color: black; font-weight: bold; text-decoration: underline;">filters/latex/latex-filter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LatexFilter::filterMessage(KTp::Message &message, const KTp::MessageContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">messageText</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="n">pos</span><span class="p">,</span> <span class="n">length</span><span class="p">,</span> <span class="n"><span class="hl">image</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">76</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">messageText</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="n">pos</span><span class="p">,</span> <span class="n">length</span><span class="p">,</span> <span class="n"><span class="hl">QString</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLatin1</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">" (%1) "</span></span><span class="p"><span class="hl">).</span></span><span class="n"><span class="hl">arg</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">numberOfFormula</span></span><span class="p"><span class="hl">)</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure about this as it references something, that is not later..well, referenced. I mean the formula should have prepended "(%1)" as well I think. This will be weird especially with longer text - "this is the formula (1) text text text text text text text text text text text text text text text text text text text text text text text text text text text text text
LaTeX"
Maybe it could be even replaced with "(formula below)"?</pre>
</blockquote>
<p>On July 14th, 2013, 7:19 p.m. UTC, <b>Daniele E. Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Usually you use [1], not (1) for citation, also I had something similar in the "code" plugin, so I think we could share a way to have references to the appended parts (perhaps have an link as well?)
Also the appended part should have the same number of the reference, or it will become confusing if you have several appended items in the same message</pre>
</blockquote>
<p>On July 14th, 2013, 8:36 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's not citations, though. I'd compare it to those "see figure 4" references in scientific literature. There the number has to be written above/bleow the figure as well, though</pre>
</blockquote>
<p>On July 15th, 2013, 1:33 p.m. UTC, <b>Daniele E. Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Agreed, but still I don't like (1), so I vote for "[1]" or "(see attachment 1)" as we could use the same for videos, code, etc. But still we need a clear way to show that "(see attachment 1)" was not written by the user, and selecting and copying that part should probably skip it, and copy the original text instead...
But this is actually not related to this patch, so I'd rather move this discussion on the bug tracker.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug here: https://bugs.kde.org/show_bug.cgi?id=322392</pre>
<br />
<p>- Daniele E.</p>
<br />
<p>On July 14th, 2013, 10:05 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Andrea Scarpino.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated July 14, 2013, 10:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix LaTeX filter
Instead of trying to put the images inline we put a reference and insert the LaTeX images at the end.
The "appended message parts" aren't affected by other filters.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">currently code renders as <img src=".... because we run before the escape filter.
If we run after we get bugs because we escape before the LaTeX can get the original code.
This fixes both of them, and makes it clearer for larger amounts of text, as otherwise line heights get confusing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/latex/latex-filter.cpp <span style="color: grey">(4e9601f095c1a3790e719b1cbbd1f32ed75c0424)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111501/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/formula.png">formula.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>