<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111440/">http://git.reviewboard.kde.org/r/111440/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9cc7ea57c830d345bab5377208058fb47b428b69 by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 8th, 2013, 8:12 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated July 8, 2013, 8:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Upgrade the Tp::Connection to include FeatureRoster inside GlobalContactManager
GlobalContactManager is useless without FeatureRoster so it makes sense
that if one instantiates this class, we upgrade the connection.
This will allow apps that only occasionally need a full contact list
such as contact-applet and text-ui to not rely on FeatureRoster in the factory and thus
can a connection object without loading details on every contact ever.
This is an important step towards a singleton AccountManager (I now have a plan), in addition
text-ui will load substantially faster.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/global-contact-manager.h <span style="color: grey">(1c903c12775c096d93fef1ec0e313ff2b2824262)</span></li>
<li>KTp/global-contact-manager.cpp <span style="color: grey">(c293e005f1ab0436dcd5c77ddc6607dba1f18896)</span></li>
<li>KTp/types.h <span style="color: grey">(652a7eadce080ff60cbfd1334c00476fe4bb4cd3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111440/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>