<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111440/">http://git.reviewboard.kde.org/r/111440/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 8th, 2013, 8:13 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought I'd shipped it before, sorry :P</pre>
</blockquote>
<p>On July 9th, 2013, 12:04 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should I put this in 0.6 (and the deactivate FeatureRoster in text-ui/contact-applet factories)?
it should make loading faster, and prevent a bug that I heard about on IRC where some guy had 10 contact-applets and they were all trying to update his avatar cache of every contact. On the other hand it's quite a large change. Also it means if you ran 0.6.3 of text-ui with 0.6.2 of ktp-common-internals it wouldn't work.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've made an executive decision.
I'll push to master, if it all works OK I may backport.</pre>
<br />
<p>- David</p>
<br />
<p>On July 8th, 2013, 8:12 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated July 8, 2013, 8:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Upgrade the Tp::Connection to include FeatureRoster inside GlobalContactManager
GlobalContactManager is useless without FeatureRoster so it makes sense
that if one instantiates this class, we upgrade the connection.
This will allow apps that only occasionally need a full contact list
such as contact-applet and text-ui to not rely on FeatureRoster in the factory and thus
can a connection object without loading details on every contact ever.
This is an important step towards a singleton AccountManager (I now have a plan), in addition
text-ui will load substantially faster.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/global-contact-manager.h <span style="color: grey">(1c903c12775c096d93fef1ec0e313ff2b2824262)</span></li>
<li>KTp/global-contact-manager.cpp <span style="color: grey">(c293e005f1ab0436dcd5c77ddc6607dba1f18896)</span></li>
<li>KTp/types.h <span style="color: grey">(652a7eadce080ff60cbfd1334c00476fe4bb4cd3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111440/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>