<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111256/">http://git.reviewboard.kde.org/r/111256/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems good, but rename the files to go with ktp naming scheme (dashes).</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 27th, 2013, 12:42 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 27, 2013, 12:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Import the KPeople KTP integration plugins
There are two plugins, one for the datasource which provides
IM data in real time.
The other is an actions plugin which provides actions that can be started on a PersonsData.
We need to provide KTp integration into libkpeople in a plugin, but we also want to access this
singleton of accounts/contacts from the other plugin and from the KTp Models. To do this a static library
ktpkpeople is created and everything links against that.
KTp Models the actions plugin and the im data source all link against this.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a83069d59fed945d04560662e3a307ef33b28332)</span></li>
<li>KTp/CMakeLists.txt <span style="color: grey">(6b3de56357ccdbf088a3781864e6826e825a5003)</span></li>
<li>KTp/Models/CMakeLists.txt <span style="color: grey">(720a5b02465b825b08d12d7c43342ad1ba69c9d1)</span></li>
<li>KTp/impersonsdatasource.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/impersonsdatasource.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/actionsplugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/actionsplugin/kpeople-actions-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/actionsplugin/kpeople-actions-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/actionsplugin/ktp_kpeople_plugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/datasourceplugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/datasourceplugin/im_persons_data_source_plugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kpeople/datasourceplugin/impersonsdatasourceplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111256/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>