<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111228/">http://git.reviewboard.kde.org/r/111228/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 25th, 2013, 9:48 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111228/diff/1/?file=165661#file165661line88" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Models/contacts-model.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KTp::ContactsModel::setAccountManager(const Tp::AccountManagerPtr &accountManager)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">source</span><span class="o">-></span><span class="n">setAccountManager</span><span class="p">(</span><span class="n">accountManager</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">source</span><span class="o">-></span><span class="n">setAccountManager</span><span class="p">(</span><span class="n">accountManager</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't you have to set the account manager for the ContactListModel?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That is what's happening - there's #ifndef</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 25th, 2013, 1:30 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 25, 2013, 1:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Switch ContactsModel between legacy mode and KPeople powered
Include a proxy model that translates between KPeople and KTp roles so that it can seemlessly support the two
--
It includes copied ktptranslationproxymodel, but renamed as it doesn't make sense to call it the KTp translation inside KTp.
Code is pushed to kpeople branch.
I want Martin to cherry-pick (w. review) useful commits on the contact-list from his branch into master till things vaguely work.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened regular ktp-contact-list.
It was trying to show things from PersonModel. It was a bit broken, unsurprisingly, as the old delegates don't support Person rows.
For some reason presence icons and avatars don't appear. This implies the translation proxy must be broken, as if we have to change the delegates, then it won't work with the legacy model. Filteringrtin
Tried running contact list plasmoid, (as that should 'just work') however we no longer have anything exposing rolenames so it doesn't work. Needs exposing into some way that can be shared. (moving setRoleNames from ContactsListModel to ContactsModel should suffice)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a83069d59fed945d04560662e3a307ef33b28332)</span></li>
<li>KTp/Models/CMakeLists.txt <span style="color: grey">(720a5b02465b825b08d12d7c43342ad1ba69c9d1)</span></li>
<li>KTp/Models/contacts-model.cpp <span style="color: grey">(9506151f5489d9a3f80f184834da26cb90141f3c)</span></li>
<li>KTp/Models/kpeopletranslationproxy.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/kpeopletranslationproxy.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111228/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>