<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111091/">http://git.reviewboard.kde.org/r/111091/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry I still have a couple of issues:
1) Instead of reading and saving the lastDownloadDirectory entry you can use the kfiledialog:///XXXXXXX syntax for file dialog (see ktp-contact-list/contact-list-widget.cpp:371). You can also use the static methods for KFileDialog, so that you don't need to add a pointer to the class.
2) I don't like at all that if you enable the "Always Ask" flag you get first a dialog to choose the directory and then, if the file exists, a second dialog to rename the file. Imho, if you enable the flag you should get just one file chooser dialog, with a warning if you are overwriting an existing file, and you should skip the checkFileExists() call and go straight to checkPartFile();</pre>
<br />
<p>- Daniele E.</p>
<br />
<p>On June 20th, 2013, 9:34 a.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated June 20, 2013, 9:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implements support for "Always Ask" for filetransfer destination directory option.
The hack with __k__onDownloadDirectoryCancelled() is necessary because KDirSelectDialog::result() always returns 0 and buttonClicked() signal is emitted even when "New Folder" button is clicked and handling that would make the code more complicated.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=295937">295937</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(ebd892c)</span></li>
<li>src/filetransfer-handler.cpp <span style="color: grey">(74c701e)</span></li>
<li>src/handle-incoming-file-transfer-channel-job.h <span style="color: grey">(d5e53c4)</span></li>
<li>src/handle-incoming-file-transfer-channel-job.cpp <span style="color: grey">(7a15237)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111091/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>