<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111099/">http://git.reviewboard.kde.org/r/111099/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 19th, 2013, 10:56 a.m. CEST, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you explain the changes please.
I'm a bit confused by the diff, I don't see why we need to make ContactGridDialog a friend class.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since KTp::ContactGridWidget is a QWidget that hides the QListView with contacts from public interface, there's no way for the KTp::ContactGridDialog to be notified about the doubleclick event. I tried installing eventFilter for Widget in the Dialog (that is widget->installEventFilter(dialog) ), but the double-click event was never delivered, so I decided to move the WidgetPrivate class into separate file and make Dialog friend of Widget, so that it can reach into the WidgetPrivate class and connect directly to itemDoubleClicked() signal of the listview.
I wanted to avoid exposing the listview into public interface of the Widget, to keep it simple and clean.</pre>
<br />
<p>- Dan</p>
<br />
<p>On June 18th, 2013, 5:14 p.m. CEST, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated June 18, 2013, 5:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This has been annoying me for ages, but I finally got around to fix it. Even though the change is a bit more invasive that one would expect for such a simple feature, I think it's worth it :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Widgets/contact-grid-dialog.h <span style="color: grey">(d9d3712)</span></li>
<li>KTp/Widgets/contact-grid-dialog.cpp <span style="color: grey">(f6eb45b)</span></li>
<li>KTp/Widgets/contact-grid-widget-private.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Widgets/contact-grid-widget.h <span style="color: grey">(d6b5468)</span></li>
<li>KTp/Widgets/contact-grid-widget.cpp <span style="color: grey">(e4ce9bc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111099/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>