<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111097/">http://git.reviewboard.kde.org/r/111097/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 8d7ff327bf342aaff7270fbe88951fb7a3097cde by Dan Vrátil to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 18th, 2013, 2:34 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated June 18, 2013, 2:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use Ktp::ContactGridDialog instead of own UI, since the grid is known to work and is sort of standard UI for contact selection in KTp.
The main advantage of of ContactGridDialog is that it has a search field, which is I think more useful than 'show online/offline' toggle, since you usually know who you want to add to the applet when you are configuring it, so you will more probably just want to type contact's name and click, instead of scrolling through a list and strcmp()'ing contact names in head :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact/CMakeLists.txt <span style="color: grey">(a94a864)</span></li>
<li>contact/src/applet_config.h <span style="color: grey">(772b7cf)</span></li>
<li>contact/src/applet_config.cpp <span style="color: grey">(52fff50)</span></li>
<li>contact/src/applet_config.ui <span style="color: grey">(1b51c46)</span></li>
<li>contact/src/telepathy-contact.h <span style="color: grey">(6d4505f)</span></li>
<li>contact/src/telepathy-contact.cpp <span style="color: grey">(9db8217)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111097/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>