<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110412/">http://git.reviewboard.kde.org/r/110412/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated May 14, 2013, 12:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We have the problem that sometimes the view doesn't get the focus when the view is open. I consider this a major bug and I'd like to fix it, although I'm unsure how to do that (I fear there's some plasma bug involved, but it's hard to tell since I cannot reproduce the bug with certainty).
This patch addresses small problems with the focus although it doesn't fix the main problem, but anyway:
- makes sure the text field doesn't have the focus when it's closed (yeah, it happens, you can write to a non-visible window :D)
- Removes a workaround I introduced thinking would be magic and solve all problems (because it's hard to reproduce). It didn't.
- Makes sure the plasmoid knows there's no currentIndex when we've closed all windows.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">plasmoidviewer FTW</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml <span style="color: grey">(165974a)</span></li>
<li>chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml <span style="color: grey">(2cc0851)</span></li>
<li>chat/org.kde.ktp-chat/contents/ui/main.qml <span style="color: grey">(1451aaa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110412/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>