<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110334/">http://git.reviewboard.kde.org/r/110334/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 9th, 2013, 10:38 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks very nice. One thing I realized though while trying this, is that we need to append the "UTC" somewhere in there, otherwise it won't make any sense.
The use case
Let's consider UTC time 15:30, in my timezone (GMT+2) that would be 17:30, in Indian timezone (GMT+5:30) that would be 21:00. So if my indian friend goes away, his presence will say eg. "I'm away from 15:30". Me reading it will automatically parse it as my timezone (because that's how we're used to understand the time we see around us), while in reality in my timezone it'd be 17:30.
So we have two options - either do something like "hh:mm UTC/GMT" or let's do "hh:mm tz" where tz is the user's timezone (so it will become "21:00 GMT+5:30". I'm not sure which one is better, so I'd be fine with either one. Oh and let's loose the seconds, that big granularity does not bring any advantage (it does not really matter to the user if it was hh:mm:07 or if it was hh:mm:51).
Finally, we should put an example in the tooltip, eg "..., for example 17:16 GMT".
Thanks for working on this!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">UTC and GMT are not the same. (they are for 6 months, but not during summer)
So to clarify what you're saying, we should replace %time with
i18n("%1 UTC").arg( QDateTi... );</pre>
<br />
<p>- David</p>
<br />
<p>On May 9th, 2013, 3:19 p.m. UTC, Lucas Betschart wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Daniele E. Domenichelli.</div>
<div>By Lucas Betschart.</div>
<p style="color: grey;"><i>Updated May 9, 2013, 3:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've added an %time option which will get replaced by the current UTC time.
To make this option visible I've changed the tool tip (I think the first thing a user would do if he wants no away message is to remove the message text [if there is one, which isn't by default], so this double information can be replaced).
Adding an extra widget for drag n drop like in now playing would be too much for this I think. It would blow up the UI if I add this under every lineedit (as more stuff is visible on the first sight for the user as more complicated it looks) and it would be confusing if I add it only once in a central place, so I decided to just inform the user through a tool tip (it's also not a important feature, so it's ok if it's a little bit hidden).</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=300849">https://bugs.kde.org/show_bug.cgi?id=300849</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autoaway.cpp <span style="color: grey">(06cb8e05d84f250e59a373461cb709ec5d400471)</span></li>
<li>config/telepathy-kded-config.cpp <span style="color: grey">(780a882858c1fed4968b71cf4c5832f9d43f7b7a)</span></li>
<li>screensaveraway.cpp <span style="color: grey">(c7fdd75aa2217a44ec849dc9acfbf20020524bdb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110334/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>