<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110291/">http://git.reviewboard.kde.org/r/110291/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit f6428585ad4204b941c44ac848264823c7239501 by Sven Brauch to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 3rd, 2013, 9:34 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated May 3, 2013, 9:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the second set of changes for the kded settings module. The changes are effectively very minor, but since I'm new to the code base I'd like to have them reviewed neverthereless. ;)
* Add a 3 pixel spacing at the top and the bottom of the icons list, as suggested on the other review request
* Disable the labels, too, not just the input widgets (makes them look greyed out); for this I rearranged the code a bit otherwise it'd get ugly
* Folder -> folder (this got lost in the diff, sorry)
Probably not much discussion is needed here. ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/nowplaying-listwidget.cpp <span style="color: grey">(13aab1a)</span></li>
<li>config/telepathy-kded-config.h <span style="color: grey">(b1bf626)</span></li>
<li>config/telepathy-kded-config.cpp <span style="color: grey">(5a7e91d)</span></li>
<li>config/telepathy-kded-config.ui <span style="color: grey">(74ce51e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110291/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>