<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110276/">http://git.reviewboard.kde.org/r/110276/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please make sure that left and right spacing fits design specification (if we have any). And the edit fields looks a little bit narrow at first glance.
>From a usability point of view I would always place edits below their caption. That makes translation easier and leads to better alignment. But in this case it would be weird to break lines.
I would sort the panels differently, ie. "Now playing" to the bottom (or into another tab).
"Auto offline": Isn't it part of the "Auto away" area? ("Sorry, it isn't.") To prevent this mistake you could rename it to "Contact list behaviour". But make this feature really sense?
Take care about short-cuts: It's not easy to access the away message, for instance. Better you provide Alt+M/E/R per "With &message" and "With m&essage" as well as "Afte&r" (second item), or the like.
"Now playing" looks quite difficult to use. If you decide to move it into another tab you could add assistance features or at least some help.
After all, settings don't have a consistent layout, so it's hard to give a good advice. Ship it, if you don't worry about a particular problem.
>Additionally, I'd like to add a dialog->resize(700, 640) to ContactListWidget::showSettingsKCM()
Is it a predefined window size? Sounds evil.</pre>
<br />
<p>- Heiko</p>
<br />
<p>On May 2nd, 2013, 9:07 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, KDE Usability, David Edmundson, and Martin Klapetek.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated May 2, 2013, 9:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch revamps the settings UI of the kded module. Especially, it removes the "flat" flag from the group boxes, and also removes lots of spacers. But talk doesn't really help with UI changes, so you'd better look at the screenshot below ;)
Additionally, I'd like to add a dialog->resize(700, 640) to ContactListWidget::showSettingsKCM() in contact-list-widget.cpp in ktp-contactlist (the function which opens the dialog), but I don't want to open a seperate review for that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The settings dialog still seems to work fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/telepathy-kded-config.cpp <span style="color: grey">(50c176d)</span></li>
<li>config/telepathy-kded-config.ui <span style="color: grey">(54ebc54)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110276/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/ktp-settings.png">Old (left) and new (right) settings dialog, with their respective default sizes</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>