<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110120/">http://git.reviewboard.kde.org/r/110120/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110120/diff/1/?file=140371#file140371line31" style="color: black; font-weight: bold; text-decoration: underline;">contactlist/org.kde.ktp-contactlist/contents/ui/ListContactDelegate.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">onClicked:</span> <span class="nx"><span class="hl">contactList</span></span><span class="p">.</span><span class="nx">startChat</span><span class="p">(</span><span class="nx">model</span><span class="p">.</span><span class="nx">account</span><span class="p">,</span> <span class="nx">model</span><span class="p">.</span><span class="nx">contact</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">onClicked:</span> <span class="nx"><span class="hl">telepathyManager</span></span><span class="p">.</span><span class="nx">startChat</span><span class="p">(</span><span class="nx">model</span><span class="p">.</span><span class="nx">account</span><span class="p">,</span> <span class="nx">model</span><span class="p">.</span><span class="nx">contact</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s2"><span class="hl">"org.freedesktop.Telepathy.Client.KTp.chatPlasmoid"</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's a bit odd... I think that hardcoding the chat plasmoid here means that there are some users who'll want windows and others who'll want plasma.
I think we should find a solution where the chats will appear in the meaningful place. I'd say that a user will expect chats to appear the same way from both contact lists.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, definitely an improvement!</pre>
<p>- Aleix</p>
<br />
<p>On April 21st, 2013, 10 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 21, 2013, 10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port Chat applet to new declarative API
Port contact list applet to new API</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Started a chat from the contact list applet (it now appears in the chat plasmoid if it's running, text-ui otherwise)
Chat plasmoid works as before
Tested removing the chat plasmoid removed the client registrar. Everything all works perfectly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contactlist/org.kde.ktp-contactlist/contents/ui/main.qml <span style="color: grey">(89a926267abe14ef7e0343ef83df0c0de0d7916e)</span></li>
<li>contactlist/org.kde.ktp-contactlist/contents/ui/ListContactDelegate.qml <span style="color: grey">(aec65b366098553c3612a6822eb2de9f013a434f)</span></li>
<li>contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml <span style="color: grey">(307563c8f99c73720602046562f4a78914e490fe)</span></li>
<li>chat/org.kde.ktp-chat/contents/ui/main.qml <span style="color: grey">(0f18b8b579b5ce72109b58df9fc808ec6763a164)</span></li>
<li>chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml <span style="color: grey">(68017c2492e738901198238e5e206379b561a49a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110120/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>