<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110061/">http://git.reviewboard.kde.org/r/110061/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 17th, 2013, 9:12 a.m. UTC, <b>Alin M Elena</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110061/diff/1/?file=139155#file139155line81" style="color: black; font-weight: bold; text-decoration: underline;">lib/chat-text-edit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ChatTextEdit::setFontBold(bool isBold)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sh</span><span class="p">.</span><span class="n">setHeight</span><span class="p">(</span><span class="n">fontMetrics</span><span class="p">().</span><span class="n">height</span><span class="p">()</span> <span class="o">+</span> <span class="mi"><span class="hl">1</span></span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">sh</span><span class="p">.</span><span class="n">setHeight</span><span class="p">(</span><span class="mi"><span class="hl">2</span></span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n">fontMetrics</span><span class="p">().</span><span class="n">height</span><span class="p">()</span> <span class="o">+</span> <span class="n"><span class="hl">fontMetrics</span></span><span class="p"><span class="hl">().</span></span><span class="n"><span class="hl">lineSpacing</span></span><span class="p"><span class="hl">()</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">do you plan to make this two configurable? allow the user to set how many lines wants?
also should not you have two linespacings?
</pre>
</blockquote>
<p>On April 17th, 2013, 9:25 a.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please do _not_ make this configurable. Starting with two lines makes sense to make it clear ot users that this is a multi-line edit box, but we do not need a user-configurable value because we use an auto-expanding box. I know that Pidgin was forked over this issue, but I think users will adjust to auto-expanding boxes over time.</pre>
</blockquote>
<p>On April 17th, 2013, 9:27 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think so, the logic is "twice the size of the font + the space between lines", which seems ok. Also I don't want to see this configurable. We can't provide configuration options for every single piece of our UIs.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wanted to give exactly these answers, thanks!</pre>
<br />
<p>- Róbert</p>
<br />
<p>On April 17th, 2013, 9:02 a.m. UTC, Róbert Szókovács wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Róbert Szókovács.</div>
<p style="color: grey;"><i>Updated April 17, 2013, 9:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes the input field's minimal size to lines high.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/chat-text-edit.cpp <span style="color: grey">(20055c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110061/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>