<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110009/">http://git.reviewboard.kde.org/r/110009/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 14th, 2013, 1:46 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/new_config.png" style="color: black; font-weight: bold; font-size: 9pt;">with new options</a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why would one want to use this?</pre>
</blockquote>
<p>On April 14th, 2013, 1:49 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To clarify (because my screenshot comment doesn't show properly) I mean in particular the option to disable seeing when other people are typing.</pre>
</blockquote>
<p>On April 14th, 2013, 2:01 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can see a point in that. Those this is not a privacy concern, I can imagine people who don't care whether someone is typing and simply find the change in window title and the line in the chat window annoying/distracting.</pre>
</blockquote>
<p>On April 14th, 2013, 2:02 p.m. UTC, <b>Stefan Eggers</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I use Skype for a chat I sometimes wait when I know the other side is typing something. Instead of waiting for them to finish (which could take a long time) I could just do something else meanwhile. Thus I turned it off in my Skype client to not get distracted this way.</pre>
</blockquote>
<p>On April 14th, 2013, 2:23 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I still don't understand, you can still (in your example) just close Skype.
Code is fine (really good in fact). I want an opinion from someone else before I click ship it.</pre>
</blockquote>
<p>On April 15th, 2013, 6:17 a.m. UTC, <b>Stefan Eggers</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To make it a bit clearer what the intended result is so it's easier to decide if this makes sense:
1) As Thomas pointed out the notification about composing a reply might be annoying and/or distracting people. Other notifications one can turn off completely, but w/o this change you can't turn off these when the other side composes a reply:
- Changing window title.
- Changing icon in the window frame.
- Changing icon in the window panel (my German system names it "Fensterleiste"; hope translated it right).
- Changing icon on the tab and changing tab name color if you happen to use multiple tabs in ktp-text-ui.
So three to four places something visually changes and no way to turn it off.
2) Closing the window will require me to reopen the window when the reply arrives. That might be in a few minutes and in that case closing the window is OK to me or it might be in a few seconds and for this case I leave the chat window open. Problem is: If I leave it open and get a notification that the other side is writing something I am tempted to just wait and see instead of first doing something else (e.g. as small as starting a build of KTP).</pre>
</blockquote>
<p>On April 15th, 2013, 9:45 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not really thrilled to have options for everything, but given the fact that we already confirmed it on bugzilla, it means we already thought about it and decided to add it. So this has a go from me.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">and from me.
Note it's my job as a maintainer to initially say "no" to everything and have the other person argue the case for it. I do it to everyone :)
(Let's make the change Dan suggested though, it will be tidier)</pre>
<br />
<p>- David</p>
<br />
<p>On April 14th, 2013, 1:44 p.m. UTC, Stefan Eggers wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Stefan Eggers.</div>
<p style="color: grey;"><i>Updated April 14, 2013, 1:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add option to show me typing (to others) and others typing (to me)
Adding two configuration options which allow to select if:
- Others get shown that I am typing.
- I get shown that others are typing.
This add the options wished for in bug 282201.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Chatted with myself (on another system). First with the option checked and then unchecked.
For the "show me typing" setting was sending something to the other side and observed that when checked I got information (on the other system) that the contact was typing and when unchecked did not.
For the "show others typing" setting was typing from the other system and observed that when checked I got informed about the activity and then unchecked did not.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=282201">282201</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.cpp <span style="color: grey">(17300d81f2fff8d2604a1d493fbc8b30cf9e169c)</span></li>
<li>config/behavior-config.h <span style="color: grey">(fa0f68615f8bb85c108392b497e3040c9463a421)</span></li>
<li>config/behavior-config.cpp <span style="color: grey">(357ede0eff85c8ac149d07c54f69c941e7e2179c)</span></li>
<li>config/behavior-config.ui <span style="color: grey">(f78393112172eda1ae8e3a768f4087bc97672cf3)</span></li>
<li>lib/channel-contact-model.cpp <span style="color: grey">(109e6b14769e362c1e9ac7af60ba49c15bb1ff47)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(a08f5e87978e121e2541480f3e9b5fdb5e5b753d)</span></li>
<li>lib/text-chat-config.h <span style="color: grey">(95c14e133cd8d7f2235010a6e5ba77f2c86996de)</span></li>
<li>lib/text-chat-config.cpp <span style="color: grey">(bbcedcf85d2c435fcd82914b96ce36be22646444)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110009/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/new_config.png">with new options</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/without_new_config.png">without new options</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>