<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110009/">http://git.reviewboard.kde.org/r/110009/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110009/diff/1/?file=138697#file138697line54" style="color: black; font-weight: bold; text-decoration: underline;">config/behavior-config.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">BehaviorConfig::BehaviorConfig(QWidget *parent, const QVariantList& args)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">ui</span><span class="o">-></span><span class="n">checkBoxShowMeTyping</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">stateChanged</span><span class="p">(</span><span class="kt">int</span><span class="p">)),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">onShowMeTypingChanged</span><span class="p">(</span><span class="kt">int</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't it be better to connect to toggled() signal and thus get only bool argument, instead of int? You don't use the tristate anyway.</pre>
</div>
<br />
<p>- Dan</p>
<br />
<p>On April 14th, 2013, 3:44 p.m. CEST, Stefan Eggers wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Stefan Eggers.</div>
<p style="color: grey;"><i>Updated April 14, 2013, 3:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add option to show me typing (to others) and others typing (to me)
Adding two configuration options which allow to select if:
- Others get shown that I am typing.
- I get shown that others are typing.
This add the options wished for in bug 282201.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Chatted with myself (on another system). First with the option checked and then unchecked.
For the "show me typing" setting was sending something to the other side and observed that when checked I got information (on the other system) that the contact was typing and when unchecked did not.
For the "show others typing" setting was typing from the other system and observed that when checked I got informed about the activity and then unchecked did not.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=282201">282201</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.cpp <span style="color: grey">(17300d81f2fff8d2604a1d493fbc8b30cf9e169c)</span></li>
<li>config/behavior-config.h <span style="color: grey">(fa0f68615f8bb85c108392b497e3040c9463a421)</span></li>
<li>config/behavior-config.cpp <span style="color: grey">(357ede0eff85c8ac149d07c54f69c941e7e2179c)</span></li>
<li>config/behavior-config.ui <span style="color: grey">(f78393112172eda1ae8e3a768f4087bc97672cf3)</span></li>
<li>lib/channel-contact-model.cpp <span style="color: grey">(109e6b14769e362c1e9ac7af60ba49c15bb1ff47)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(a08f5e87978e121e2541480f3e9b5fdb5e5b753d)</span></li>
<li>lib/text-chat-config.h <span style="color: grey">(95c14e133cd8d7f2235010a6e5ba77f2c86996de)</span></li>
<li>lib/text-chat-config.cpp <span style="color: grey">(bbcedcf85d2c435fcd82914b96ce36be22646444)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110009/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/new_config.png">with new options</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/14/without_new_config.png">without new options</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>