<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109835/">http://git.reviewboard.kde.org/r/109835/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice patch.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109835/diff/1/?file=128988#file128988line368" style="color: black; font-weight: bold; text-decoration: underline;">lib/adium-theme-view.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void AdiumThemeView::clear()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">368</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">messageInfo</span><span class="p">.</span><span class="n">setUserIconPath</span><span class="p">(</span><span class="n">message</span><span class="p">.</span><span class="n">senderAvatarPath</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know you added KTp::Message::senderAvatar(), but I haven't found senderAvatarPath()</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109835/diff/1/?file=128990#file128990line468" style="color: black; font-weight: bold; text-decoration: underline;">lib/chat-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ChatWidget::setupContactModelSignals()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">468</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">chatviewlInitialised</span> <span class="o">=</span> <span class="nb">true</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since you are touching the code, could you fix the typo?
chatViewlInitialised -> chatViewInitialised
</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109835/diff/1/?file=128992#file128992line164" style="color: black; font-weight: bold; text-decoration: underline;">lib/logmanager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LogManager::onDatesFinished(Tpl::PendingOperation *po)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">164</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">event</span><span class="o">-></span><span class="n">sender</span><span class="p">()</span><span class="o">-></span><span class="n">identifier</span><span class="p">()</span> <span class="o">==</span> <span class="n">m_account</span><span class="o">-></span><span class="n">normalizedName</span><span class="p">())</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">163</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">//</span> if (event->sender()->identifier() == m_account->normalizedName()) {</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You can probably remove all the commented code</pre>
</div>
<br />
<p>- Dan</p>
<br />
<p>On April 3rd, 2013, 2:14 p.m. CEST, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 3, 2013, 2:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move AdiumContentInfo to be internal to AdiumThemeView
AdiumThemeView now takes a KTp::Message which contains all the information needed to present information in the view.
/me messages are passed as KTp::Messages, in future status messages will be too.
I also had to fix entity model to take KTp::ContactPtr because of a conflict in Qt MetaTypes after including KTp code. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/appearance-config-tab.cpp <span style="color: grey">(fadfd474a9b702c5e24046790eb19ceb0e34a8b5)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(70618f66ff374c9775391eb0890beb6fddcffd5c)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(361cd6da826f6d684ddd1a145a6c719848745134)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(95b86f8c52429c4cd759fb46538a67d40161f6de)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(5787940f071d46fa209de5650de20a42a305bd4e)</span></li>
<li>lib/logmanager.h <span style="color: grey">(9b1d010717a153206fabf448dd1502d3d61a7917)</span></li>
<li>lib/logmanager.cpp <span style="color: grey">(a570adfaaf7b1b03aab246ddbf1ba4cd5ae22733)</span></li>
<li>logviewer/entity-model-item.h <span style="color: grey">(47d98cdb7ac90efc54ca9ee1df880b8e7b6f9843)</span></li>
<li>logviewer/entity-model-item.cpp <span style="color: grey">(a08ccc221e89510ca2057b63d0fffdc7ca459ce2)</span></li>
<li>logviewer/entity-model.h <span style="color: grey">(5c9aa73d621c8d21601fab892890f5ae7c60e28c)</span></li>
<li>logviewer/entity-model.cpp <span style="color: grey">(1c10c1d758a4eb0f7792fa1660effefccecc24f2)</span></li>
<li>logviewer/entity-proxy-model.cpp <span style="color: grey">(67811f61c1c5a2d2fa35534af1228f7b726e8706)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(5c2e2140b03da68d64177b0ef1ea994b95e6e94c)</span></li>
<li>logviewer/main.cpp <span style="color: grey">(48d5ee2813241e6659eb032a517994dcb4220b63)</span></li>
<li>logviewer/message-view.cpp <span style="color: grey">(6a59caa0b40b528fc69497e8ba4d42f683a74e65)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109835/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>