<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109807/">http://git.reviewboard.kde.org/r/109807/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9b8f17433a7b14b256c1eb9272186c0f00ab416f by Dominik Cermak to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 31st, 2013, 4:50 p.m. UTC, Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated March 31, 2013, 4:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stop using mission-controls ConnectAutomatically for autoconnect, instead use our kded-module only.
The diff looks worse than it is. Most of the old code has been deleted, one new method has been added, but the unified diff mixes this all...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still testing if race conditions occur (auth-handler/kwallet timeout). So far no problems.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=307175">307175</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autoconnect.h <span style="color: grey">(e296012586a67aed88a87e2c166ff526ab0fa76d)</span></li>
<li>autoconnect.cpp <span style="color: grey">(526b060db162e81accb6da0d1d81cb6dd22c43c0)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(a28bca86f03e971ec7d68b62d69c8802d1b05677)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109807/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>