<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109726/">http://git.reviewboard.kde.org/r/109726/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 97dc73527aecaad4c5ac6337cb0affc599c6d1ad by David Edmundson to branch kde-telepathy-0.6.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 26th, 2013, 6:05 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 26, 2013, 6:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix crashes when using debug versions of Qt
Rewrite the logic of sourceDataChanged which was fundamentally broken
This was potentially emitting onDataChanged on the invalid QModelIndex,
especially now we use a flat model in the filtered view</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked it no longer crashes; Online contacts count worked correctly when Martin went offline and back.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/contacts-model.cpp <span style="color: grey">(f472c9c538d48b8ff7b5fc63ce72e478835c71a5)</span></li>
<li>KTp/Models/contacts-filter-model.cpp <span style="color: grey">(d3bfb326f54053c82f67124e7bc33278b1b77899)</span></li>
<li>KTp/Models/contacts-filter-model.h <span style="color: grey">(f5b41a505058be9b55703cd7cb6787c8d399bc7e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109726/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>