<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109560/">http://git.reviewboard.kde.org/r/109560/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 18th, 2013, 7:09 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand why you go so low-level. There must be some wrapper in either Qt or KWindowSystem</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">grep would imply otherwise.
Qt takes it from the application name, but I don't think it's safe to change that without side effects.
note that this code is practically taken from PlasmaApp which also does this.</pre>
<br />
<p>- David</p>
<br />
<p>On March 18th, 2013, 3:01 a.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Martin Gräßlin.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 18, 2013, 3:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Provide a static method to set WmClass
This allows us to group all KTp windows together
See https://bugs.kde.org/show_bug.cgi?id=298470
After using it, I'm not 100% sure I want the change. Lets keep all discussion on that on bugzilla.
CC'ing Martin G because it involves X and he really likes X.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added corresponding line to both the contact list and text-ui.
Both windows showed when I pressed cntrl+F7 also both share the same icon in the task manager.
TBH, I'm not sure I like the behaviour.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(def690d62d0bbba56acf318a73a193bbc2f45994)</span></li>
<li>KTp/telepathy-handler-application.h <span style="color: grey">(4f8a059cdcb54bffcc12e179151bf190ef170fc2)</span></li>
<li>KTp/telepathy-handler-application.cpp <span style="color: grey">(8056dd1b55a1c74dfbb4dfa7357887a0afb54f9d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109560/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>