<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109403/">http://git.reviewboard.kde.org/r/109403/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 71c92b36407a1d66c19e066b0f0c7b7fef89615c by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 13th, 2013, 5:33 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 13, 2013, 5:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a new class for processing outgoing messages
Currently we re-use KTp::Message when the filters process a message to be sent, this exposes a lot of setters and getters that have no use at all.
It also mixes HTML and plain text which has already led to one bug, and would probably lead to more.
This keeps the API cleaner and simpler
--
This is an API and ABI break in the middle of a feature freeze, which is normally against the results.
I want this patch in because I want the API to be sensible for people to start writing their own plugins, I don't want them to break them for 0.7</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(323afb3c965f28eeea84f51956b7aa55a7b5588e)</span></li>
<li>KTp/CMakeLists.txt <span style="color: grey">(448425593b6b1c2f0191c03e54871b7f7bc87ff5)</span></li>
<li>KTp/abstract-message-filter.h <span style="color: grey">(cf26907c5849b4df4ad725b2a5f7cb9f73953866)</span></li>
<li>KTp/abstract-message-filter.cpp <span style="color: grey">(06d805db1e9e440ae95cdd0368c8ba3212c2bc4e)</span></li>
<li>KTp/message-processor.h <span style="color: grey">(a22fc707a22f9171728d859387d21eff99afdbe2)</span></li>
<li>KTp/message-processor.cpp <span style="color: grey">(2e252f9e81b622c5673f0037cd127f3381a337b4)</span></li>
<li>KTp/outgoing-message.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/outgoing-message.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109403/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>