<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109466/">http://git.reviewboard.kde.org/r/109466/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c971c72970192ab6bd2df246fa53c44028ff0093 by Roman Nazarenko to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 13th, 2013, 4:54 p.m. UTC, Roman Nazarenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Roman Nazarenko.</div>
<p style="color: grey;"><i>Updated March 13, 2013, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">09:00 pm <d_ed> ok, imagine you have the setting "open tabs in a new window'
09:00 pm <d_ed> you open window 1
09:00 pm <d_ed> it gets the right action, things are good
09:00 pm <d_ed> you open window 2
09:00 pm <d_ed> you get the action for the first window
09:00 pm <d_ed> things still work
09:00 pm <d_ed> you close window 1
09:00 pm <d_ed> that KAction* is now deleted
09:00 pm <d_ed> you type in window 2.. crash
Fixed by using local KShortcut objects in every TextEdit widget.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=316484">316484</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.h <span style="color: grey">(a92cb75)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(02a390e)</span></li>
<li>lib/chat-text-edit.h <span style="color: grey">(7611924)</span></li>
<li>lib/chat-text-edit.cpp <span style="color: grey">(00c3f47)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(9eecc89)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(4416d68)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109466/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>