<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109445/">http://git.reviewboard.kde.org/r/109445/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Suffered same thing in kscreen, the patch is quite neat since you are setting the var instead of for example adding both in the link (as we did)</pre>
<br />
<p>- Àlex</p>
<br />
<p>On March 11th, 2013, 10:04 p.m. UTC, Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 10:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">build would fail with
/build/buildd/ktp-auth-handler-0.6.0+git20130310+r86/x-messenger-oauth2-prompt.cpp:203: undefined reference to `QJson::Parser::Parser()'
/build/buildd/ktp-auth-handler-0.6.0+git20130310+r86/x-messenger-oauth2-prompt.cpp:206: undefined reference to `QJson::Parser::parse(QByteArray const&, bool*)'
/build/buildd/ktp-auth-handler-0.6.0+git20130310+r86/x-messenger-oauth2-prompt.cpp:232: undefined reference to `QJson::Parser::~Parser()
because /usr/lib/x86_64-linux-gnu/cmake/qjson/qjson-config.cmake ships lower case prefixed defines:
SET(qjson_LIBRARIES "/usr/lib/x86_64-linux-gnu/libqjson.so" CACHE FILEPATH "Libraries for qjson")
SET(qjson_INCLUDE_DIR "/usr/include" CACHE PATH "Include path for qjson")
SET(qjson_FOUND "TRUE")
i still wonder why qjson_FOUND works though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build successfull on ubuntu 12.10 with quantal</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=316564">316564</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindQJSON.cmake <span style="color: grey">(fad59050d8df1326d07fa6aacac1eb31346f67ba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109445/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>