<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109432/">http://git.reviewboard.kde.org/r/109432/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"I think this will have problems with Gtalk's contact ids like 235jb7ggtg01m20rtksena9sa1@public.talk.google.com - I'm not sure if these are auto-generated from some key or what, but if each connection generates new id, then this will be quite useless."
If that was the case your entire nepomuk plans are completely ruined.
Fortunately for you, it is the same each time :)</pre>
<br />
<p>- David</p>
<br />
<p>On March 11th, 2013, 6:56 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 6:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This stores the avatar tokens in a config file, which can be reused in KTp::Contact::avatar() - if we don't have avatar available from Tp, we check the config file and see if we have cached token. This will be another patch.
I think this will have problems with Gtalk's contact ids like 235jb7ggtg01m20rtksena9sa1@public.talk.google.com - I'm not sure if these are auto-generated from some key or what, but if each connection generates new id, then this will be quite useless.
EDIT: I missed the telepathy-module.cpp in the diff where it adds the AvatarToken feature.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Config file properly stored.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=315939">315939</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contactnotify.h <span style="color: grey">(9018114)</span></li>
<li>contactnotify.cpp <span style="color: grey">(ad82a73)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(1c986b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109432/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>