<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109202/">http://git.reviewboard.kde.org/r/109202/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David</p>
<br />
<p>On March 1st, 2013, 9:23 a.m. UTC, Roman Nazarenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Roman Nazarenko.</div>
<p style="color: grey;"><i>Updated March 1, 2013, 9:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch is a mess. QTextEdit handles Key_Return, we need to save Key_Return from passing to QTextEdit, but we need to know KAction shortcut. And that shortcut is stored in ChatWindow, which is located far away in the QObject parenting tree.
This patch allows user to configure custom shortcut, but standard shortcut (Key_Return) is still working. I have no idea how to disable it without types casting hell.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=308894">https://bugs.kde.org/show_bug.cgi?id=308894</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.h <span style="color: grey">(018e91a)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(c79e3aa)</span></li>
<li>lib/chat-text-edit.h <span style="color: grey">(4279ce5)</span></li>
<li>lib/chat-text-edit.cpp <span style="color: grey">(19fdb38)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109202/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>