<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109202/">http://git.reviewboard.kde.org/r/109202/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 28th, 2013, 5:26 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109202/diff/2/?file=116240#file116240line111" style="color: black; font-weight: bold; text-decoration: underline;">lib/chat-text-edit.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QSize ChatTextEdit::sizeHint() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">e</span><span class="o">-></span><span class="n">key</span><span class="p">()</span><span class="o">==</span><span class="n">Qt</span><span class="o">::</span><span class="n">Key_Return</span> <span class="o">||</span> <span class="n">e</span><span class="o">-></span><span class="n">key</span><span class="p">()</span><span class="o">==</span><span class="n">Qt</span><span class="o">::</span><span class="n">Key_Enter</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">e</span><span class="o">-></span><span class="n">modifiers</span><span class="p">())</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">111</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">e</span><span class="o">-></span><span class="n">modifiers</span><span class="p">()</span> <span class="o">&&</span> <span class="n">m_sendMessageAction</span> <span class="o">&&</span> <span class="n">m_sendMessageAction</span><span class="o">-></span><span class="n">shortcut</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">QKeySequence</span><span class="p">(</span><span class="n">e</span><span class="o">-></span><span class="n">key</span><span class="p">())))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This won't work if you set the send message shortcut to shift + enter.
e->modifiers() is now non zero, so we would skip sending the message.
I think we want e->matches(m_sendMessageAction->shortcut());</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">edit: what I said won't work.
but you do need to check the e->key and e->modifiers in the event and shortcut are the same.</pre>
<br />
<p>- David</p>
<br />
<p>On February 28th, 2013, 5:03 p.m. UTC, Roman Nazarenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Roman Nazarenko.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2013, 5:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch is a mess. QTextEdit handles Key_Return, we need to save Key_Return from passing to QTextEdit, but we need to know KAction shortcut. And that shortcut is stored in ChatWindow, which is located far away in the QObject parenting tree.
This patch allows user to configure custom shortcut, but standard shortcut (Key_Return) is still working. I have no idea how to disable it without types casting hell.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=308894">https://bugs.kde.org/show_bug.cgi?id=308894</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.h <span style="color: grey">(018e91a)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(c79e3aa)</span></li>
<li>lib/chat-text-edit.h <span style="color: grey">(4279ce5)</span></li>
<li>lib/chat-text-edit.cpp <span style="color: grey">(19fdb38)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(2c85f3b)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(e7adc5a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109202/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>