<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109165/">http://git.reviewboard.kde.org/r/109165/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 26th, 2013, 1:59 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like the principle.
This sort of conflicts with what I started here https://git.reviewboard.kde.org/r/108895/ where I put startTextChat into the TpController/AccountManager wrapper QObject class. I put in a startTextChat and intended to have what you've just done here. If we go with my approach, I'll copy and paste all the code you've just done here. I'll do an update tonight.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm.. well, good thing about this approach is that we have a clear mapping of the api from c++.
Another option would be to make KTp::Actions a QObject and the function, slots.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On February 26th, 2013, 3:26 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2013, 3:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QML can't deal with namespaces, provide a way to.
It probably should be developed further into providing feedback on the requests, but...
http://www.sureiscute.com/images/50360e401d41c87726000130.jpg
On the other hand, with this we can drop files to a delegate and it will send the file (i wanted to upload the patch but RB is not accepting the patch for some reason... I'll try again tomorrow)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Declarative/CMakeLists.txt <span style="color: grey">(3865c13)</span></li>
<li>KTp/Declarative/declarative-ktp-actions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Declarative/declarative-ktp-actions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Declarative/qml-plugins.cpp <span style="color: grey">(7bf1c41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109165/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>