<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109158/">http://git.reviewboard.kde.org/r/109158/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 26th, 2013, 6:33 p.m. UTC, <b>Nikita Skovoroda</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't like something about it, needs some checks.
I'll do them a bit later today.</pre>
</blockquote>
<p>On February 26th, 2013, 6:43 p.m. UTC, <b>Nikita Skovoroda</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are checking for .contains(), but using the whole value.
The «v» parameter in «http://youtube.com/?v=idf32"></iframe><div>…</div><iframe%20src="» contains QRegExp validId(QLatin1String("[a-zA-Z0-9_-]+")).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can't check it from master right now, slow internet connection.
I'll be able to fully test it when I'll be home tommorow in the evening.
If you can, please test it on the following url: http://youtube.com/?v=i%22%3E%3C%2Fiframe%3E%3Cdiv+style%3D%22position%3Aabsolute%3Bleft%3A0%3Bright%3A0%3Btop%3A0%3Bbottom%3A0%3Bfont-size%3A30px%3Btext-align%3Acenter%3Bbackground%3Ared%3Bcolor%3Ablack%22%3EHello%2C+world%21%3C%2Fdiv%3E%3Ciframe+src%3D%22
I'm not sure about this one, if it does nothing, I'll better check everything myself when I'll be able to get the code.</pre>
<br />
<p>- Nikita</p>
<br />
<p>On February 25th, 2013, 9:31 p.m. UTC, Lasath Fernando wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson and Nikita Skovoroda.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2013, 9:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since there was little hope of getting that giant demotivating patch merged all in one go, I thought I may as well submit little patches as I have time.
I cherry picked the commit that added the Youtube filter, and then changed the code to make it work with the current MessageProcessor.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sent myself cool videos. ;-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/CMakeLists.txt <span style="color: grey">(2f88157)</span></li>
<li>filters/youtube/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/youtube/ktptextui_message_filter_youtube.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/youtube/youtube-filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/youtube/youtube-filter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109158/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>