<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106763/">http://git.reviewboard.kde.org/r/106763/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 17th, 2013, 12:24 p.m. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pretty nice. Arrow orientation is okay but I would remove group icons. As far as I see they don't add information and, if group icons are omitted, white space makes grouping more effective.</pre>
</blockquote>
<p>On February 17th, 2013, 12:33 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with the group icons, they are useless. There are however account icons (when in accounts grouping mode), which you can choose yourself. So leave them when in accounts mode but remove (useless) group icons?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uh, option all-around ;-).
I'm fine with your solution. Ship it!</pre>
<br />
<p>- Heiko</p>
<br />
<p>On February 17th, 2013, 12:35 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and KDE Usability.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2013, 12:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I made several improvements to the group header in contact list:
1) Moved the expand sign to the right
2) Removed the tiny line
3) Made the account/group icon slightly bigger (has the same size as the avatar in normal mode; might need adjusting)
4) Aligned both the icon and the font with the contacts
5) Used background color from palette disabled:highlight and lighter by factor of 10
This is more a visual review request than a code, I tried with several default KDE color schemes and I think it looks good in all of them, see the screenshot below. Let me know what you think (and if possible try using the patch for a while yourself and see how it fits).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>abstract-contact-delegate.cpp <span style="color: grey">(836913f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106763/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/headers_2.png">Take Two</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/headers_3.png">accounts mode</a></li>
</ul>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106763/s/757/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/cl_new_header_composed_400x100.png" style="border: 1px black solid;" alt="New group header" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>