<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107264/">http://git.reviewboard.kde.org/r/107264/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 9th, 2012, 4:09 p.m. CET, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's not true, they're in the context menu
I would argue that:
1) they're not settings relating to the plasmoid, so don't belong there
2) they don't physically fit without resizing
(did you know the battery applet only shows the configs there because the author didn't know how to add it to a context menu)
Justify the decision to me.</pre>
</blockquote>
<p>On November 9th, 2012, 4:21 p.m. CET, <b>Dan Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Look on it from this POV: left click on "Instant Messaging Presence settings" - now do you see anything that would allow you to configure instant messaging presence?
Secondly, there is no way to access the KDE Integration configuration page from the applet context menu.
</pre>
</blockquote>
<p>On November 16th, 2012, 10:05 a.m. CET, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Left clicking on presence applet doesn't let you get to the plasmoid config (and therefore this) either.
2) Well that's just a bug. It doesn't justify doing it differently.
I made a list:
- Battery applet shows Solid settings in the plasmoid settings
- Network Manager has a link in the main applet to the networking KCM and shows it in the plasmoid settings
- Device Notifier does not link to hotplug KCM
- Pager shows virtual desktop settings in the plasmoid settings.
- Clock has to "adjust date & time" KCM link in the context menu
- Nepomuk Controller "applet" links to KCM in the context menu.
Personally, I'm against applets configuring things other than the applet and think the clock applet has it right, but it's not particularly consistent across the standard widgets. Maybe we should email plasma-devel?
So, I'm not really in favour of this patch but it's not "wrong" either so I'm not against it either.
If you get a ship it from someone else, go for it.</pre>
</blockquote>
<p>On November 16th, 2012, 1:55 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Concerning the battery plasmoid settings (which now resize properly, so it is an issue in the telepathy KCM, not the plasmoid!), I think you cannot add entries to the context menu when it is a pure QML plasmoid?
I'd say it is percetly valid to add related settings to the plasmoid. I like that I am able to configure the power management settings from the battery plasmoid or device actions from the device notifier.</pre>
</blockquote>
<p>On November 16th, 2012, 2:27 p.m. CET, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To clarify, the KTp config does resize properly with this patch . I assumed (before testing) that it would not because of the battery one.
My initial comment that it would not resize, is incorrect.
</pre>
</blockquote>
<p>On November 16th, 2012, 2:31 p.m. CET, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, okay. Yeah that bug in the battery plasmoid was due to some issues in the PowerDevil KCM, it had nested containers (QWidget inside QScrollArea inside a layout inside the KCM) and so probably some Qt bug caused the embedded KCM to not set a proper sizehint and so the dialog was not properly sized. I fixed that, and as a side-effect that fixed the missing gradient in the KCM as well. Just FYI :)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since Dave does not like this patch, is there anyone else who would give me 'Ship it', or should I just close this review?</pre>
<br />
<p>- Dan</p>
<br />
<p>On November 9th, 2012, 2:13 p.m. CET, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2012, 2:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Atm the applet configuration dialog shows only the Plasma default pages, which is silly. Let's add the KCM Accounts and KDE Integration pages there!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7becc7e)</span></li>
<li>src/presenceapplet.h <span style="color: grey">(5b462fc)</span></li>
<li>src/presenceapplet.cpp <span style="color: grey">(33fc8cc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107264/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>