<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108846/">http://git.reviewboard.kde.org/r/108846/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6ed91fd966758a28260ae45ff909dd299cf5e1a9 by David Edmundson on behalf of Stefan Eggers to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 8th, 2013, 9:50 a.m. UTC, Stefan Eggers wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Stefan Eggers.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2013, 9:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">when offline, hide add contact SNI</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- add two accounts A and B in a local ejabber server
- account A adds account B to contact list
- approval request shows up in account B when B comes online
- stop ejabber server so that B is offline
- with this patch the approval request does not show anymore while B stays offline; it comes back when B is online again</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=294478">294478</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact-request-handler.h <span style="color: grey">(43456ee8f0a354ed075335d80a125da51713a0e9)</span></li>
<li>contact-request-handler.cpp <span style="color: grey">(f40f397e86393716cebf128630b2c4c43691930e)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(7ab13b26f8d52648c2c33c0fde0ff1648181c8c4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108846/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>