<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108831/">http://git.reviewboard.kde.org/r/108831/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e0092cb6f885268c223b8a2634b91ced757d4066 by Aleix Pol to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 7th, 2013, 10:53 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2013, 10:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch does 2 main things:
- cleans up the delegate to use PlasmaComponents.ListItem instead of a custom highlighter.
- Fixes the plasmoid initialization, when setting the sorting and filter. it was using .model instead of .filter. (it wasn't filtering or sorting anything before...)
- Prefer IconItem to QIconItem, this is better because it's a little smarter and more efficient (see marco's blog posts). It has a downside that adds a dependency on KDE 4.10, which I'm unsure if it's acceptable.
Hope you like it!
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I ran the contact list on the plasmoid viewer while coding</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml <span style="color: grey">(2f0ea05)</span></li>
<li>contactlist/org.kde.ktp-contactlist/contents/ui/ListContactDelegate.qml <span style="color: grey">(9bf73d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108831/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>