<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108791/">http://git.reviewboard.kde.org/r/108791/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 8a2ab704e6e19c6a06c753a1ed75efd7a29161c0 by Dan Vrátil to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 4th, 2013, 11:17 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2013, 11:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uses QCA2 to verify the certificate chain. CA certs are read from KSslCertificateManager. Exception rules are stored in KSslCertificateManager too. This means that we now share certificates and exceptions with the rest of KDE \o/. However in order to use KSslCertificateManager and KSslInfoDialog I had to import several private headers from kdelibs.
The dialogs are copied from KIO::TcpSlaveBase, so they look exactly like kio_http.
If you set a "remember forever" rule during testing and you want to remove it, remove it from ~/.kde/share/config/ksslcertificatemanager and restart KDED.
I had to remove -DQT_NO_CAST_FROM_ASCII and -DQT_NO_KEYWORDS because QCA2 and kdelibs headers wouldn't compile otherwise.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265315">265315</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(417554a)</span></li>
<li>kssl/kssl.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kssl/ksslcertificatemanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kssl/ksslinfodialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kssl/ksslsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>main.cpp <span style="color: grey">(3350658)</span></li>
<li>tls-cert-verifier-op.h <span style="color: grey">(121cf41)</span></li>
<li>tls-cert-verifier-op.cpp <span style="color: grey">(c94999e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108791/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>