<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108791/">http://git.reviewboard.kde.org/r/108791/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2013, 12:50 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108791/diff/1/?file=112181#file112181line232" style="color: black; font-weight: bold; text-decoration: underline;">tls-cert-verifier-op.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">206</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dialog</span><span class="o">-></span><span class="n">exec</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">read up on the kdialog crash.
http://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
Putting dialog as a QWeakPointer (so it is set to 0 if deleted) should be enough.</pre>
</blockquote>
<p>On February 6th, 2013, 1:36 p.m. UTC, <b>Dan Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The dialog pointer is alrady wrapped in QPointer</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so it is :)</pre>
<br />
<p>- David</p>
<br />
<p>On February 4th, 2013, 11:17 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2013, 11:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Uses QCA2 to verify the certificate chain. CA certs are read from KSslCertificateManager. Exception rules are stored in KSslCertificateManager too. This means that we now share certificates and exceptions with the rest of KDE \o/. However in order to use KSslCertificateManager and KSslInfoDialog I had to import several private headers from kdelibs.
The dialogs are copied from KIO::TcpSlaveBase, so they look exactly like kio_http.
If you set a "remember forever" rule during testing and you want to remove it, remove it from ~/.kde/share/config/ksslcertificatemanager and restart KDED.
I had to remove -DQT_NO_CAST_FROM_ASCII and -DQT_NO_KEYWORDS because QCA2 and kdelibs headers wouldn't compile otherwise.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265315">265315</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(417554a)</span></li>
<li>kssl/kssl.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kssl/ksslcertificatemanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kssl/ksslinfodialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kssl/ksslsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>main.cpp <span style="color: grey">(3350658)</span></li>
<li>tls-cert-verifier-op.h <span style="color: grey">(121cf41)</span></li>
<li>tls-cert-verifier-op.cpp <span style="color: grey">(c94999e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108791/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>