<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108720/">http://git.reviewboard.kde.org/r/108720/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6c3d59666c8040bb556bc3af60c79d6545263faf by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 6th, 2013, 5:19 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2013, 5:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Generally fix MessageProcessor to match the original design
- Make Message constructor private and a friend class of the message processor. This simplifies code, and makes accidentally skipping the escape filtering impossible
- Message now has two extra properties isHistory and messageDirection
- Message filters have access to the "message context" the account/channel in which the message was received
- Remove the broken filterIncomingMessage / filterOutgoingMessages with just one method. Plugins can use messageDirection to get the same functionality
This is a setup to fix a range of bugs in the message filters
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(ed2ab3e2c26903ee359c514deefc6d0042f099c0)</span></li>
<li>KTp/Declarative/conversation.cpp <span style="color: grey">(b7a87db6d2cfe002b39c0038e9870a534206e5d2)</span></li>
<li>KTp/Declarative/messages-model.h <span style="color: grey">(162a2487960a876f47848c3a92021faa06aae91e)</span></li>
<li>KTp/Declarative/messages-model.cpp <span style="color: grey">(c8b6e8d0bde5e515e156fe59b901eb8227541c76)</span></li>
<li>KTp/abstract-message-filter.h <span style="color: grey">(fe85a9ad16960bf8d31cb0968fe9c71867457722)</span></li>
<li>KTp/abstract-message-filter.cpp <span style="color: grey">(111903826fd871eec20c8f5eda54667f24a88d58)</span></li>
<li>KTp/message-backslash-filter.cpp <span style="color: grey">(c91522e30a15737c84f53cac98845944a0479aea)</span></li>
<li>KTp/message-context.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/message-context.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/message-escape-filter.cpp <span style="color: grey">(696389b0d303be01ea2f79d0389b146ec8773c91)</span></li>
<li>KTp/message-filters-private.h <span style="color: grey">(02e2230c0f8c42d36f61a1010cbe3d584a591670)</span></li>
<li>KTp/message-processor.h <span style="color: grey">(47f66e9c470acb53fc8e25a6bd183e7ccd03b463)</span></li>
<li>KTp/message-processor.cpp <span style="color: grey">(760e36910c7eaf770e31ce122889c02a732a4913)</span></li>
<li>KTp/message-url-filter.cpp <span style="color: grey">(24b652290ea8fbd9349e7a08e609378826ae1c55)</span></li>
<li>KTp/message.h <span style="color: grey">(581a2e20d025a972e8b58ae5e2635a381d000011)</span></li>
<li>KTp/message.cpp <span style="color: grey">(d814a996d7e07d0cea70ddcff11ad7e00b904614)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108720/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>