<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108153/">http://git.reviewboard.kde.org/r/108153/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 9c720566f0ae32f1de5358cdae7a134e2841000a by David Edmundson on behalf of Stefan Eggers to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 20th, 2013, 12:02 p.m. UTC, Stefan Eggers wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Stefan Eggers.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2013, 12:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix height for local-xmpp list view
The list item was slightly smaller than the containing list view for
small font sizes. When it was selected there was a small strip below
which didn't belong to the item and didn't change color. Fixed this.
For really large fonts the list view didn't get high enough and thus
got truncated. This gets fixed at the same time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I set the font size to 5 for all fonts to see if the bug is fixed. Without this change I get a white strip (see the linked picture in the bug report). With the change there is no white strip anymore.
I also tested a case of a really large font with font size 48. Without this change the second line of text was truncated, with the change it was looking right.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309050">309050</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcm-telepathy-accounts.cpp <span style="color: grey">(9ca5949bc9ec90d1e2356fbe89afb8c298eeb14c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108153/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>