<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108498/">http://git.reviewboard.kde.org/r/108498/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4e0c9f95f0e43ce22d37e4811af7b8d196925f46 by Dan Vrátil to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 20th, 2013, 2 a.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2013, 2 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KTp::ContactInfoDialog is a dialog very similar to the contact info dialog in contact list, but it displays more detailed information, like full name, homepage, birthday etc.
I moved the dialog to ktp-common-internals, so that it can be shared between contactlist and kded module - see bug https://bugs.kde.org/show_bug.cgi?id=298764.
The dialog also supports editing mode (see screenshots), when you open the dialog with "yourself" (that's contact == account->connection->selfContact). This feature could be used in KCM for instance. Unfortunately when I was almost finished, I found out, that TelepathyQt4 does not have API for editing contact information (RAGE!), so the editing code is disabled for now. Upstream patch is already waiting for review: https://bugs.freedesktop.org/show_bug.cgi?id=59609</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(10c17bf)</span></li>
<li>KTp/contact-info-dialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/contact-info-dialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108498/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/contactdialog.png">contactdialog.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/contactdialog-edit.png">contactdialog-edit.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>