<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108558/">http://git.reviewboard.kde.org/r/108558/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about calling the method setCurrentAccount, so that it's complimentary to currentAccount() and it's more clear that it can be used anytime to change selection.
Bonus for the documentation :)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108558/diff/1/?file=108896#file108896line55" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Widgets/accounts-combo-box.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">itemData</span><span class="p">(</span><span class="n">currentIndex</span><span class="p">(),</span> <span class="n">AccountsListModel</span><span class="o">::</span><span class="n">AccountRole</span><span class="p">).</span><span class="n">value</span><span class="o"><</span><span class="n">Tp</span><span class="o">::</span><span class="n">AccountPtr</span><span class="o">></span><span class="p">()</span><span class="o">-></span><span class="n">uniqueIdentifier</span><span class="p">()</span> <span class="o">==</span> <span class="n">selectedAccountId</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should be itemData(i, role) I guess</pre>
</div>
<br />
<p>- Dan</p>
<br />
<p>On January 22nd, 2013, 8:30 p.m. CET, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2013, 8:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a method to AccountsComboBox to pre-select an account.
This came up from porting the call UI. Not having this will result in a regression (one could do it by looping through the QComboBox, but I'd rather internalise everything). Will probably be useful for Join Chat Room dialog too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Widgets/accounts-combo-box.h <span style="color: grey">(b5a17dacabd2428d46788028507995de129eb556)</span></li>
<li>KTp/Widgets/accounts-combo-box.cpp <span style="color: grey">(d1ffbacd44e3e5d525ad4bd0c153defbfa9709f1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108558/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>