<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108401/">http://git.reviewboard.kde.org/r/108401/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Almost forgot, I had to add some changes because having Q_DECLARE_METATYPE in the header file is quite broken and has some problems. Please review that.
I'd suggest to leave it like that and reconsider outside this review.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On January 14th, 2013, 4:02 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2013, 4:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.
The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.
** This is the library part after the split. You can follow the discussion in https://git.reviewboard.kde.org/r/107811/ **</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the chat plasmoid</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: grey">(12d0654)</span></li>
<li>KTp/Declarative/CMakeLists.txt <span style="color: grey">(17fea5a)</span></li>
<li>KTp/Declarative/contact-pin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Declarative/contact-pin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Declarative/conversation-target.h <span style="color: grey">(cce2138)</span></li>
<li>KTp/Declarative/conversation-target.cpp <span style="color: grey">(99d2176)</span></li>
<li>KTp/Declarative/conversation.h <span style="color: grey">(4b277eb)</span></li>
<li>KTp/Declarative/conversation.cpp <span style="color: grey">(afd58e3)</span></li>
<li>KTp/Declarative/conversations-model.h <span style="color: grey">(c0d0128)</span></li>
<li>KTp/Declarative/conversations-model.cpp <span style="color: grey">(fe564ac)</span></li>
<li>KTp/Declarative/messages-model.h <span style="color: grey">(4ad2ff8)</span></li>
<li>KTp/Declarative/messages-model.cpp <span style="color: grey">(0553f0b)</span></li>
<li>KTp/Declarative/pinned-contacts-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Declarative/pinned-contacts-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Declarative/qml-plugins.cpp <span style="color: grey">(d1dfbea)</span></li>
<li>KTp/Declarative/telepathy-text-observer.h <span style="color: grey">(4f2a028)</span></li>
<li>KTp/Declarative/telepathy-text-observer.cpp <span style="color: grey">(98dfced)</span></li>
<li>KTp/Models/contacts-model.h <span style="color: grey">(e352569)</span></li>
<li>KTp/ktp-metatypes.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108401/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>