<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108018/">http://git.reviewboard.kde.org/r/108018/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 610e9a4585e87d837332af2ac074e49f1de38bc3 by Dan Vrátil to branch model_refactor_2.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 30th, 2012, 2:17 a.m., Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 2:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AccountsTreeProxyModel
- remove debugging messages (looks useless to me)
ContactsFilterModel
- make OnlineUsersCountRole and TotalUsersCountRole work with ContactsListModel as source model. Did not test with ContactsModel, but it should now work with both of them (essentially I had to port the code away from GroupsModelItem and AccountsModelItem since these are ContactsModel-specific).
ContactsListModel
- emit changed() when contact's group membership changes
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ContactsFilterModel
- online/total contacts counts are correctly displayed with both grouping types
ContactsListModel
- moving contact to a different group updates the model as expected</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/abstract-grouping-proxy-model.cpp <span style="color: grey">(533d545)</span></li>
<li>KTp/Models/accounts-tree-proxy-model.h <span style="color: grey">(98bab16)</span></li>
<li>KTp/Models/accounts-tree-proxy-model.cpp <span style="color: grey">(e5ad725)</span></li>
<li>KTp/Models/contacts-filter-model.cpp <span style="color: grey">(269505c)</span></li>
<li>KTp/Models/contacts-list-model.cpp <span style="color: grey">(219ee5f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108018/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>