<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107417/">http://git.reviewboard.kde.org/r/107417/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 22nd, 2012, 1:36 p.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="http://git.reviewboard.kde.org/r/107417/s/848/" style="color: black; font-weight: bold; font-size: 9pt;">after.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/107417/s/848/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/22/after_599_438_60_105.png" style="border: 1px black solid;" alt="After"></a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't check the patch, but there is still something wrong in the alignment here...
Also the scrollbar disappeared, so I wonder if you can still scroll to get the items that disappear if the i18n'ed names are long</pre>
</blockquote>
<p>On November 23rd, 2012, 12:18 p.m., <b>Othmane Moustaouda</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In order to show the difference I had to resize the window at the minimum size possibile, the list widget appears as truncated because its minimum size is the size that contains all items</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Imho this is fix will cause other problems, but there is probably no easy solution.
By looking at what Amarok does I found that their list widget is just big enough to show the scrollbar when needed, without changing the item disposition, see http://wstaw.org/m/2012/11/23/snapshot111.png , but it looks better because they have bigger icons.
What do you think?</pre>
<br />
<p>- Daniele Elmo</p>
<br />
<p>On November 22nd, 2012, 11:03 a.m., Othmane Moustaouda wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Othmane Moustaouda.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2012, 11:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This single line patch fixes bug 309819 - "Now playing settings groupbox has wasted empty space"
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=309819">309819</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/nowplaying-listwidget.cpp <span style="color: grey">(0262f48553537470d34e29b9b0b1450eca855ce8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107417/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107417/s/847/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/22/before_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/107417/s/848/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/22/after_400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>