<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107408/">http://git.reviewboard.kde.org/r/107408/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6857be3a56573a91e8bd76bb874375cfd5793348 by Dan Vrátil to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 21st, 2012, 3:55 p.m., Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2012, 3:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds following main menu to the logviewer main window:
File
- Quit
Logs
- Clear account history
- Clear contact history
-----------------------
- Import Kopete Logs
Conversation
- Previous Conversation (Ctrl+P)
- Next Conversation (Ctrl+N)
Settings
Help
(The last two menus contain default KXmlGuiWindow actions, I decided to omit the "Glorify dvratil" action).
I converted the LogViewer class from QWidget to KXmlGuiWindow and since I was already digging in the code, I moved the Tp Factories initialization to main(), renamed some slots, moved some code etc - no major changes, it just makes me happier when reading the code.
The new feature (because of which I decided to do this all) are "Previous Conversation" and "Next Conversation" actions. I'm bored scrolling all the way up in long chats to reach the "Previous Conversation" link on the beginning of the log. Having these two actions allows me to do this just by using keyboard shortcuts ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like everything still works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>logviewer/CMakeLists.txt <span style="color: grey">(3953dc1)</span></li>
<li>logviewer/log-viewer.h <span style="color: grey">(8829e7b)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(13db0c4)</span></li>
<li>logviewer/log-viewer.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>logviewer/main.cpp <span style="color: grey">(e7eb0b5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107408/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>