<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107203/">http://git.reviewboard.kde.org/r/107203/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note: merging this is on hold as I want to change GlobalContactManager. Will update this in due course</pre>
<br />
<p>- David</p>
<br />
<p>On November 20th, 2012, 10:44 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2012, 10:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port ContactRequestHandler to use new GlobalContactManager class
This removes a lot of code \o/ and is generally more readable.
Also links the account to the newly added contact which will be useful for a future patche.
--
Code Tidy. Do not use "using namespace" in a header file.
Doing so means any file that happens to include this header now has a namespace implicitly set. This breaks the entire point of namespaces.
CCMAIL: rohangarg@kubuntu.org</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact-request-handler.h <span style="color: grey">(43456ee8f0a354ed075335d80a125da51713a0e9)</span></li>
<li>contact-request-handler.cpp <span style="color: grey">(ea24885970f46cecc58000d3330a3e2be2d39581)</span></li>
<li>contactnotify.h <span style="color: grey">(462b3f3fe5f00efd330b0e07da52422b0b30ee74)</span></li>
<li>contactnotify.cpp <span style="color: grey">(65bdaac8d273eb0a3d76eee406e34877e1649e59)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107203/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>