<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107345/">http://git.reviewboard.kde.org/r/107345/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">code is fine from a Tp POV (I don't know about the nepomuk stuff)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/107345/diff/1/?file=94907#file94907line18" style="color: black; font-weight: bold; text-decoration: underline;">capabilities-hack-private.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef CAPABILITIES_HACK_PRIVATE_H</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not a fan of code duplication.
However if this is a "temporary" workaround, I'll let it off.
</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On November 16th, 2012, 5:27 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Vishesh Handa.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2012, 5:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The feeder was using the streamedMedia..(..) calls to detected capabilities, but these are deprecated now with Call1. This copies the capabilities detection from AccountsModel/ContactsModel, so the feeder actually feeds proper informations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Capabilities are properly detected, however they are not properly stored in Nepomuk. I've checked all the code and it all looks fine, so it must be with the graph saving. Here's a scenairo where it fails:
1. Contact is online in some client, only text capability is available
2. Contact switches clients/logs in some other client with audio/video caps
3. Capabilities are properly detected, properly placed in the resource, pushed into the graph
3.1. With text capability, there is now also audio and video capabilities in the resource
4. After pushing it, Nepomuk contains only the audio & video capabilities, the text one is gone
5. If the capabilities change again (tested with back to text-only), it updates properly in Nepomuk
Vishesh, do you have any idea what might be wrong here?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>capabilities-hack-private.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(aa0907f)</span></li>
<li>abstract-storage.h <span style="color: grey">(b6aa32e)</span></li>
<li>account.h <span style="color: grey">(0cac18c)</span></li>
<li>account.cpp <span style="color: grey">(4fef2b2)</span></li>
<li>capabilities-hack-private.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>contact.h <span style="color: grey">(e8d7044)</span></li>
<li>contact.cpp <span style="color: grey">(9bc953d)</span></li>
<li>controller.cpp <span style="color: grey">(8e7dcf8)</span></li>
<li>nepomuk-storage.h <span style="color: grey">(05c6acb)</span></li>
<li>nepomuk-storage.cpp <span style="color: grey">(25d432d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107345/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>