<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107319/">http://git.reviewboard.kde.org/r/107319/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 726c954e88fc9a71abf259e1fd21740a7c2beef4 by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 14th, 2012, 5:42 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2012, 5:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Turns out I wanted to break the API all over again :)
--
Use a custom AccountsListModel role to show enabled state and not Qt::CheckStateRole which is application specific.
This was causing checkboxes to appear in combo boxes showing a list of accounts
Also remove flags method which no longer has any effect on anything.
AccountsListModel now takes an AccountSet to know which accounts to show
--
We can't make it share the AccountsFilterModel, it doesn't really make sense to have one filter model that can cope with two different source roles and completely different usages.
(as DrDanz suggested in an earlier review, this filter should be renamed to ContactsFilterModel, but I'm delaying that till we know what's happening with that.)
Right now only AccountsKCM uses this model. A patch for that is being uploaded alongside.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/accounts-list-model.h <span style="color: grey">(f205a6973c1de54a188afb601866020b2f014898)</span></li>
<li>KTp/Models/accounts-list-model.cpp <span style="color: grey">(d46011ac04efd2b00dadc0b45b8cce77aff386ff)</span></li>
<li>KTp/Widgets/accounts-combo-box.h <span style="color: grey">(92d6d993ed01028eedfedddb3eea8ff82539559c)</span></li>
<li>KTp/Widgets/accounts-combo-box.cpp <span style="color: grey">(d427e9bf004053482aa3c592052b89f1e1f01f13)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107319/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>